repo
stringclasses
15 values
fix_commit
stringlengths
40
40
buggy_commit
stringlengths
40
40
message
stringlengths
3
64.3k
files
listlengths
1
300
timestamp
timestamp[s]date
2013-03-13 20:45:00
2026-04-11 07:48:46
nodejs/node
2a0e5de16367828f1222830e930721386e26f90b
ccf46ba0f5ce02ae85b8bdb5e29acfc376caf9fc
debugger: use `internal/url.URL` instead of `url.parse` PR-URL: https://github.com/nodejs/node/pull/49590 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Rev...
[ { "path": "lib/internal/debugger/inspect_client.js", "patch": "@@ -15,7 +15,7 @@ const crypto = require('crypto');\n const { ERR_DEBUGGER_ERROR } = require('internal/errors').codes;\n const { EventEmitter } = require('events');\n const http = require('http');\n-const URL = require('url');\n+const { URL } = ...
2023-09-11T08:36:00
golang/go
8c52cd3da550f5315c32bdcb9442ac50e3e4ec96
441770461f5ed7a042b79a8e092c53e8ab393f3e
cmd/internal/obj: make asmidx error less cryptic It's still pretty cryptic, but at least now instead of printing asm: asmidx: bad address 0/2067/2068 it will print asm: asmidx: bad address 0/BX/SP Change-Id: I1c73c439c94c5b9d3039728db85102a818739db9 Reviewed-on: https://go-review.googlesource.com/c/go/+/61...
[ { "path": "src/cmd/internal/obj/x86/asm6.go", "patch": "@@ -3506,7 +3506,7 @@ bas:\n \treturn\n \n bad:\n-\tctxt.Diag(\"asmidx: bad address %d/%d/%d\", scale, index, base)\n+\tctxt.Diag(\"asmidx: bad address %d/%s/%s\", scale, rconv(index), rconv(base))\n \tab.Put1(0)\n }\n ", "additions": 1, "delet...
2024-09-06T11:19:18
electron/electron
320bea4c287a04287c798cf177be7c657b672564
59ab79417d82d9900d24e686a0b23451d6612539
feat: add fuses for NODE_OPTIONS and --inspect (#30190) * feat: add fuses for NODE_OPTIONS and --inspect * chore: add node patch to ensure NODE_OPTIONS are never parsed when fuse is disabledd * chore: fix lint * chore: flip boolean logic * chore: update patches * chore: add trailing _ to static member ...
[ { "path": "build/fuses/fuses.json5", "patch": "@@ -3,5 +3,7 @@\n \"_schema\": \"0 == off, 1 == on, r == removed fuse\",\n \"_version\": 1,\n \"run_as_node\": \"1\",\n- \"cookie_encryption\": \"0\"\n+ \"cookie_encryption\": \"0\",\n+ \"node_options\": \"1\",\n+ \"node_cli_inspect\": \"1\"\n }", ...
2021-08-05T17:50:11
facebook/react
d63cd972454125d4572bb8ffbfeccbdf0c5eb27b
ddb1ab1e97588136a3db736696bbc3c8cf9f0210
don't stringify objects for console log second render (#24373) Fixes #24302 based on #24306. --- The current implementation for strict mode double logging stringiness and dims the second log. However, because we stringify everything, including objects, this causes objects to be logged as `[object Object]` etc. ...
[ { "path": "packages/react-devtools-shared/src/__tests__/console-test.js", "patch": "@@ -494,20 +494,31 @@ describe('console', () => {\n );\n expect(mockLog.mock.calls[0]).toHaveLength(1);\n expect(mockLog.mock.calls[0][0]).toBe('log');\n- expect(mockLog.mock.calls[1]).toHaveLength(2);\n- e...
2022-04-14T16:30:04
vercel/next.js
29c27e83207547ccbe18c1dd1ec9c1eabf919225
df77469085412d7c04b196214ae361d132ccc2d9
[test] Fix flaky error-recovery test (#76789) Fixes https://github.com/vercel/next.js/actions/runs/13651039022/job/38159568577?pr=76787#step:33:639 Sometimes we didn't get to assert in time before more errors come in. Now the test ensures that each error is intentional.
[ { "path": "test/development/acceptance-app/error-recovery.test.ts", "patch": "@@ -534,28 +534,31 @@ describe('Error recovery app', () => {\n outdent`\n import * as React from 'react';\n let i = 0\n- setInterval(() => {\n- i++\n- throw Error('no ' + i)\n- ...
2025-03-04T12:46:24
nodejs/node
668437ccada33c03bb454a19c61b030c028076b0
e4d1259e5fd90484036995011b6419a7b8d04dc8
deps: V8: cherry-pick b60a03df4ceb Original commit message: [api] mark v8::Script and v8::UnboundScript as v8::Data v8::UnboundModuleScript and v8::Module are already v8::Data. Mark v8::Script and v8::UnboundScript as v8::Data so that they can be used in other V8 APIs that takes v8::Data. Refs: ...
[ { "path": "common.gypi", "patch": "@@ -36,7 +36,7 @@\n \n # Reset this number to 0 on major V8 upgrades.\n # Increment by one for each non-official patch applied to deps/v8.\n- 'v8_embedder_string': '-node.16',\n+ 'v8_embedder_string': '-node.17',\n \n ##### V8 defaults for Node.js #####\n...
2023-09-12T10:04:27
rust-lang/rust
156b08184ebeadfc2968bfc454defaab44df20cd
3b282feee64d8a62918246dffc0b7a373dd935b3
fix(single_range_in_vec_init): don't apply the suggestion automatically
[ { "path": "clippy_lints/src/single_range_in_vec_init.rs", "patch": "@@ -98,7 +98,7 @@ impl LateLintPass<'_> for SingleRangeInVecInit {\n && snippet.starts_with(suggested_type.starts_with())\n && snippet.ends_with(suggested_type.ends_with())\n {\n- let mut applicabi...
2026-01-08T19:04:50
golang/go
441770461f5ed7a042b79a8e092c53e8ab393f3e
8e478de4e6c91a0de763cf2e308f7598677f5c58
cmd/cgo: add srcdir & trimpath docs, sort options Update the package docs: * The -srcdir docs were accidentally lost in CL 68590. * The -trimpath option was added in CL 266358 but not documented. * The options were not sorted correctly. Fixes #69730 Change-Id: I97320e0f4fb6aa47cb03d451f028d3d9d9b560f7 Reviewed-on: h...
[ { "path": "src/cmd/cgo/doc.go", "patch": "@@ -545,15 +545,6 @@ The following options are available when running cgo directly:\n \t\tIf there are any exported functions, write the\n \t\tgenerated export declarations to file.\n \t\tC code can #include this to see the declarations.\n-\t-importpath string\n-\t\...
2024-10-01T16:57:52
facebook/react
ddb1ab1e97588136a3db736696bbc3c8cf9f0210
168da8d55782f3b34e2a6aa0c4dd0587696afdbd
Rename react-dom/testing to react-dom/unstable_testing in yarn build-for-devtools (#24364) The shell package wasn't compiling because yarn build-for-devtools was incorrect. The react-dom/test package was renamed to react-dom/unstable_testing. This PR fixes this in the package.json. Note: Adding packages to the yarn...
[ { "path": "package.json", "patch": "@@ -108,7 +108,7 @@\n \"scripts\": {\n \"build\": \"node ./scripts/rollup/build.js\",\n \"build-combined\": \"node ./scripts/rollup/build-all-release-channels.js\",\n- \"build-for-devtools\": \"cross-env RELEASE_CHANNEL=experimental yarn build react/index,rea...
2022-04-13T18:07:26
electron/electron
481b774fd7c19cb753224b85c9d520a5acf01836
acbd643e2ad524b05ef2b804dd34114d7486761f
docs: crashpad on linux lands in 16, not 15. (#30387)
[ { "path": "docs/breaking-changes.md", "patch": "@@ -12,7 +12,7 @@ This document uses the following convention to categorize breaking changes:\n * **Deprecated:** An API was marked as deprecated. The API will continue to function, but will emit a deprecation warning, and will be removed in a future release.\...
2021-08-04T17:16:05
vercel/next.js
df77469085412d7c04b196214ae361d132ccc2d9
ab00c8765022712b59b37071ecae91c1093f4790
[test] Use new Redbox matchers in server-navigation-error (#76787)
[ { "path": "test/development/app-dir/server-navigation-error/server-navigation-error.test.ts", "patch": "@@ -1,9 +1,4 @@\n import { nextTestSetup } from 'e2e-utils'\n-import {\n- assertHasRedbox,\n- getRedboxDescription,\n- getRedboxSource,\n-} from 'next-test-utils'\n \n describe('server-navigation-error...
2025-03-04T10:50:26
nodejs/node
d3e0331953117a58570eb4c2da513d8ecd8d47af
d8b378cb3f632f5e390465aff11ac5dcb4ef63ff
errors: use `determineSpecificType` in more error messages PR-URL: https://github.com/nodejs/node/pull/49580 Fixes: https://github.com/nodejs/node/issues/49576 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
[ { "path": "lib/internal/errors.js", "patch": "@@ -1349,17 +1349,11 @@ E('ERR_INVALID_REPL_EVAL_CONFIG',\n E('ERR_INVALID_REPL_INPUT', '%s', TypeError);\n E('ERR_INVALID_RETURN_PROPERTY', (input, name, prop, value) => {\n return `Expected a valid ${input} to be returned for the \"${prop}\" from the` +\n- ...
2023-09-11T23:18:58
rust-lang/rust
bdb1050a0f433be29982de0668102ec15a2c9b96
0cfc4ee541d819e7cf93cdebb1c43fd0d9eb444b
fix: don't lint if `std` or `core` are required for a suggestion but unavailable
[ { "path": "clippy_lints/src/methods/unnecessary_sort_by.rs", "patch": "@@ -190,6 +190,12 @@ pub(super) fn check<'tcx>(\n } else {\n \"sort_by_key\"\n };\n+ let Some(std_or_core) = std_or_core(cx) else {\n+ // To make it this far the crate has...
2026-01-07T15:42:15
facebook/react
168da8d55782f3b34e2a6aa0c4dd0587696afdbd
8bc527a4cf3e7e8b15ad0312cd49b438181103f2
Fix typo that happened during rebasing I changed the type of this functions returned value but forgot to change the check. It happens to work before anyway, because eventually the interleaved updates will get transferred at the beginning of the next render phase. But this is more logically consistent.
[ { "path": "packages/react-reconciler/src/ReactFiberWorkLoop.new.js", "patch": "@@ -732,7 +732,7 @@ export function isInterleavedUpdate(fiber: Fiber, lane: Lane) {\n // defensive coding measure in case a new update comes in between when\n // rendering has finished and when the interleaved updates...
2022-04-12T19:41:34
electron/electron
97929eab5f5396570be41de388e759eeaba57482
1c29734c91ad7e45f852372ac4e6c6b6278b10a4
fix: move window buttons in-place on macOS (#30322)
[ { "path": "filenames.gni", "patch": "@@ -180,8 +180,8 @@ filenames = {\n \"shell/browser/ui/cocoa/root_view_mac.mm\",\n \"shell/browser/ui/cocoa/views_delegate_mac.h\",\n \"shell/browser/ui/cocoa/views_delegate_mac.mm\",\n- \"shell/browser/ui/cocoa/window_buttons_view.h\",\n- \"shell/brows...
2021-08-04T00:31:12
rust-lang/rust
68365697b3ab5e57c7a4e1cc4878e9a77ef002ae
3b282feee64d8a62918246dffc0b7a373dd935b3
A `return` in an iterator closure should not trigger `never_loop` The iterator never loops when the closure used in, e.g., `.any()`, panics, not when it diverges as a regular `return` lets the iterator continue.
[ { "path": "clippy_lints/src/loops/never_loop.rs", "patch": "@@ -4,8 +4,8 @@ use clippy_utils::diagnostics::span_lint_and_then;\n use clippy_utils::higher::ForLoop;\n use clippy_utils::macros::root_macro_call_first_node;\n use clippy_utils::source::{snippet, snippet_with_context};\n-use clippy_utils::sym;\n ...
2026-01-08T18:33:24
vercel/next.js
7bac0c49e5a70e069ba23ae6f6721c6657ebe9d0
059c255c37f7ddd5b56af4a21150fc06ef2b63cd
[test] Use new Redbox matchers in app/ dynamic-error-trace (#76783)
[ { "path": "test/development/acceptance-app/dynamic-error.test.ts", "patch": "@@ -1,49 +0,0 @@\n-/* eslint-env jest */\n-import { createSandbox } from 'development-sandbox'\n-import { FileRef, nextTestSetup } from 'e2e-utils'\n-import path from 'path'\n-import { outdent } from 'outdent'\n-\n-describe('dynami...
2025-03-04T10:01:08
golang/go
8e478de4e6c91a0de763cf2e308f7598677f5c58
b37b27b595898f6c5e65e3c78d76bc50caef8622
net: document possible networks that can be passed to Control Before this patch, the documentation of Dialer.Control and ListenConfig.Control did not specify what networks would be passed to the Control function other than the "tcp" case. It was thus challenging to use the Control function to filter out certain networ...
[ { "path": "src/net/dial.go", "patch": "@@ -203,8 +203,10 @@ type Dialer struct {\n \t// connection but before actually dialing.\n \t//\n \t// Network and address parameters passed to Control function are not\n-\t// necessarily the ones passed to Dial. For example, passing \"tcp\" to Dial\n-\t// will cause t...
2024-10-01T10:49:19
nodejs/node
d8b378cb3f632f5e390465aff11ac5dcb4ef63ff
48fcb205e4577fd0096f6b772ca250c6dbf759e3
fs: fix readdir and opendir recursive with unknown file types If the libuv operations invoked by `readdir`/`opendir` return `uv_dirent_t` values where the `type` is `UV_DIRENT_UNKNOWN` then a further `lstat` is issued to fully construct the `Dirent` values. In the recursive versions of these functions, the `path` para...
[ { "path": "lib/internal/fs/dir.js", "patch": "@@ -152,7 +152,7 @@ class Dir {\n ArrayPrototypePush(\n this[kDirBufferedEntries],\n getDirent(\n- pathModule.join(path, result[i]),\n+ path,\n result[i],\n result[i + 1],\n ),\n@@ -161,9 +161,1...
2023-09-11T19:08:08
facebook/react
8bc527a4cf3e7e8b15ad0312cd49b438181103f2
f7cf077cca6524877cb837adb9a8ff54242672b1
Bugfix: Fix race condition between interleaved and non-interleaved updates (#24353) * Regression test: Interleaved update race condition Demonstrates the bug reported in #24350. * Bugfix: Last update wins, even if interleaved "Interleaved" updates are updates that are scheduled while a render is already in p...
[ { "path": "packages/react-reconciler/src/ReactFiberInterleavedUpdates.new.js", "patch": "@@ -28,6 +28,10 @@ export function pushInterleavedQueue(\n }\n }\n \n+export function hasInterleavedUpdates() {\n+ return interleavedQueues !== null;\n+}\n+\n export function enqueueInterleavedUpdates() {\n // Tran...
2022-04-12T19:39:11
rust-lang/rust
1eb605f6346055b91acbb23cdaa81284abe4aa70
32fe406b5e71afbb0d8b95280e50e67d1549224c
Query associated_item_def_ids when needed This commit moves a query to `associated_item_defs` from above an error condition caused independently of it to below it. It looks generally cleaner and might potentially save some runtime in case the error condition is met, rendering `items` to be left unused, yet still quer...
[ { "path": "compiler/rustc_hir_analysis/src/coherence/inherent_impls.rs", "patch": "@@ -79,13 +79,12 @@ impl<'tcx> InherentCollect<'tcx> {\n }\n \n if self.tcx.features().rustc_attrs() {\n- let items = self.tcx.associated_item_def_ids(impl_def_id);\n-\n if !self.tcx.has...
2026-01-08T18:41:24
electron/electron
1c29734c91ad7e45f852372ac4e6c6b6278b10a4
81793496258b20c6134ea14843cbc91a0315d566
build: fix building with enable_desktop_capturer = false (#30372)
[ { "path": "shell/common/crash_keys.cc", "patch": "@@ -14,6 +14,7 @@\n #include \"base/strings/string_split.h\"\n #include \"components/crash/core/common/crash_key.h\"\n #include \"content/public/common/content_switches.h\"\n+#include \"electron/buildflags/buildflags.h\"\n #include \"electron/fuses.h\"\n #in...
2021-08-03T22:12:46
vercel/next.js
5d53fd00fb8cf183c8bc20090b09aa46abe29330
f5f5be6b358c7d9697339279ce913e5a990de056
[test] Use new Redbox matchers in pages/ service-side-dev-errors (#76779)
[ { "path": "test/integration/server-side-dev-errors/test/index.test.js", "patch": "@@ -4,12 +4,10 @@ import fs from 'fs/promises'\n import { join } from 'path'\n import webdriver from 'next-webdriver'\n import {\n- assertHasRedbox,\n killApp,\n findPort,\n launchApp,\n retry,\n- getRedboxSource,\n ...
2025-03-04T09:24:38
golang/go
b37b27b595898f6c5e65e3c78d76bc50caef8622
e470a00cdff2c4c13162dc8887fedd6812393514
cmd/cgo: document errno value semantics Added a section about errno values vs normal go error value semantics, and checking the return value of C functions for error before looking at errno. Fixes #63485 Change-Id: Id0132a9f11e4127f4adc14e010b7e17f57a0f7d3 Reviewed-on: https://go-review.googlesource.com/c/go/+/61626...
[ { "path": "src/cmd/cgo/doc.go", "patch": "@@ -209,6 +209,17 @@ function returns void). For example:\n \t_, err := C.voidFunc()\n \tvar n, err = C.sqrt(1)\n \n+Note that the C errno value may be non-zero, and thus the err result may be\n+non-nil, even if the function call is successful. Unlike normal Go conv...
2024-09-27T20:09:11
rust-lang/rust
0cfc4ee541d819e7cf93cdebb1c43fd0d9eb444b
a4f0937a9a28b4e1faacfc3ae1281e568d0ad59c
fix: respect applicability reduction due to `Sugg` By postponing the creation of `Sugg`s, we can properly account for their effect on applicability
[ { "path": "clippy_lints/src/methods/unnecessary_sort_by.rs", "patch": "@@ -1,4 +1,4 @@\n-use clippy_utils::diagnostics::span_lint_and_sugg;\n+use clippy_utils::diagnostics::span_lint_and_then;\n use clippy_utils::res::{MaybeDef, MaybeTypeckRes};\n use clippy_utils::std_or_core;\n use clippy_utils::sugg::Sug...
2026-01-07T15:25:41
facebook/react
4fc394bbecdf55e46d192536e1a545376f90d84b
80170a0681def183f8f3153425f1086d3d383922
Fix suspense fallback throttling (#24253) * fix suspense throttling * fix lint * Tweak tests + another test Co-authored-by: Dan Abramov <dan.abramov@gmail.com>
[ { "path": "packages/react-reconciler/src/ReactFiberCommitWork.new.js", "patch": "@@ -2209,17 +2209,22 @@ function commitMutationEffectsOnFiber(\n recursivelyTraverseMutationEffects(root, finishedWork, lanes);\n commitReconciliationEffects(finishedWork);\n \n- if (flags & Visibility) {\n- ...
2022-04-12T14:42:05
nodejs/node
65d396b0a0a0a7d343f7d022fe591f93df532bbb
31657f73f13aab8897cdf2ddf4ac27a7a4bace1d
test: use spawnSyncAndExitWithoutError in sea tests To display more information when the command fails. PR-URL: https://github.com/nodejs/node/pull/49543 Refs: https://github.com/nodejs/reliability/issues/658 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
[ { "path": "test/sequential/test-single-executable-application-snapshot-and-code-cache.js", "patch": "@@ -13,7 +13,9 @@ skipIfSingleExecutableIsNotSupported();\n \n const tmpdir = require('../common/tmpdir');\n const { copyFileSync, writeFileSync, existsSync } = require('fs');\n-const { spawnSync } = require...
2023-09-07T20:03:03
electron/electron
a17e48061ac488a2d4b030fc380ff3fcfc640a14
40e76dca0719ee7d725d29898ff995b7cb2781d1
fix: console window popping up when --enable-logging passed on windows (#30375)
[ { "path": "patches/chromium/.patches", "patch": "@@ -102,3 +102,4 @@ refactor_restore_base_adaptcallbackforrepeating.patch\n hack_to_allow_gclient_sync_with_host_os_mac_on_linux_in_ci.patch\n don_t_run_pcscan_notifythreadcreated_if_pcscan_is_disabled.patch\n add_gin_wrappable_crash_key.patch\n+logging_win32...
2021-08-03T21:09:02
vercel/next.js
32de0d9a0fc8e9675e354d431ebadbce2193890b
4bb686dee9b48a5cebc2ad6feda1b8504024ca43
Fix canary only warning for devlow-bench (#76772) These are failing our canary only check for stable releases so adds necessary env to avoid this. x-ref: https://github.com/vercel/next.js/actions/runs/13641536096/job/38133462655
[ { "path": "scripts/devlow-bench.mjs", "patch": "@@ -40,6 +40,8 @@ const nextBuildWorkflow =\n PWD: process.env.PWD,\n NEXT_TRACE_UPLOAD_DISABLED: 'true',\n NEXT_PRIVATE_SKIP_CANARY_CHECK: 'true',\n+ // Enable next.js test mode to get HMR events and silence canary only\n+ ...
2025-03-03T23:03:49
golang/go
e470a00cdff2c4c13162dc8887fedd6812393514
89228ca439b7ecfc4fa6641e79bb3119e600e519
test: fix test issue 69434 for riscv64 CL 615915 simplified test for issue 69434, using gcflags maymorestack to force stack moving, making program failed with invalid stack pointer. However, it seems that this maymorestack is broken on riscv64. At least gotip-linux-riscv64 is currently broken. This CL fixes this pro...
[ { "path": "test/fixedbugs/issue69434.go", "patch": "@@ -1,4 +1,4 @@\n-// run -gcflags=-d=maymorestack=runtime.mayMoreStackMove\n+// run\n \n // Copyright 2024 The Go Authors. All rights reserved.\n // Use of this source code is governed by a BSD-style\n@@ -13,6 +13,7 @@ import (\n func All() iter.Seq[int] {...
2024-10-01T09:50:04
rust-lang/rust
6ed95301410f592c97b4a7499fb22ea087148291
32fe406b5e71afbb0d8b95280e50e67d1549224c
tests/ui/borrowck/issue-92157.rs: Remove (bug not fixed)
[ { "path": "src/tools/tidy/src/issues.txt", "patch": "@@ -379,7 +379,6 @@ ui/borrowck/issue-88434-minimal-example.rs\n ui/borrowck/issue-88434-removal-index-should-be-less.rs\n ui/borrowck/issue-91206.rs\n ui/borrowck/issue-92015.rs\n-ui/borrowck/issue-92157.rs\n ui/borrowck/issue-93078.rs\n ui/borrowck/issu...
2026-01-08T17:21:54
facebook/react
80170a0681def183f8f3153425f1086d3d383922
fea6f8da6ab669469f2fa3f18bd3a831f00ab284
Match bundle.name and match upper case entry points (#24346) Fix matching in the build script. It's possible to provide a custom bundle name in the case we build deep imports. We should match those names as a convenience. The script also calls toLowerCase on requested names but some entries have upper case now...
[ { "path": "scripts/rollup/build.js", "patch": "@@ -438,13 +438,21 @@ function shouldSkipBundle(bundle, bundleType) {\n }\n }\n if (requestedBundleNames.length > 0) {\n+ // If the name ends with `something/index` we only match if the\n+ // entry ends in something. Such as `react-dom/index` only...
2022-04-12T01:01:48
nodejs/node
31657f73f13aab8897cdf2ddf4ac27a7a4bace1d
dca4d84349fc23c7f0aff28df6734568ef5b9ffe
test: use spawnSyncAndExitWithoutError in test/common/sea.js To display more information when the command fails. PR-URL: https://github.com/nodejs/node/pull/49543 Refs: https://github.com/nodejs/reliability/issues/658 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
[ { "path": "test/common/sea.js", "patch": "@@ -4,7 +4,9 @@ const common = require('../common');\n const fixtures = require('../common/fixtures');\n \n const { readFileSync } = require('fs');\n-const { execFileSync } = require('child_process');\n+const {\n+ spawnSyncAndExitWithoutError,\n+} = require('../com...
2023-09-07T20:02:28
electron/electron
40e76dca0719ee7d725d29898ff995b7cb2781d1
6e43b0bcbf17667e826bb64b551cb16e3f8bd9b9
feat: switch to crashpad on linux (#30278)
[ { "path": "docs/api/crash-reporter.md", "patch": "@@ -19,56 +19,22 @@ following projects:\n * [socorro](https://github.com/mozilla/socorro)\n * [mini-breakpad-server](https://github.com/electron/mini-breakpad-server)\n \n+> **Note:** Electron uses Crashpad, not Breakpad, to collect and upload\n+> crashes, b...
2021-08-03T21:01:12
vercel/next.js
4bb686dee9b48a5cebc2ad6feda1b8504024ca43
15a0dee80a6fb2f41fdeb10ca5e42e59eb979228
Fix: respond 405 status code on OPTIONS request to SSG page (#76767) ### What? The behavior of `OPTIONS` requests differs depending on whether the page is an SSG page or not: - For **SSG pages**, we return a `405 Method Not Allowed` status code ([#34346](https://github.com/vercel/next.js/pull/34346)). - Otherwise, w...
[ { "path": "packages/next/src/server/base-server.ts", "patch": "@@ -2247,7 +2247,7 @@ export default abstract class Server<\n ) {\n res.statusCode = 405\n res.setHeader('Allow', ['GET', 'HEAD'])\n- await this.renderError(null, req, res, pathname)\n+ res.body('Method Not Allowed').se...
2025-03-03T22:59:22
golang/go
89228ca439b7ecfc4fa6641e79bb3119e600e519
8194d735cff90871b1ea5c92e83ddd50abdd4185
runtime/pprof: add context to short stack panic Over the years we've had various bugs in pprof stack handling resulting in appendLocsForStack crashing because stk is too short for a cached location. i.e., the cached location claims several inlined frames. Those should always appear together in stk. If some frames are ...
[ { "path": "src/runtime/pprof/proto.go", "patch": "@@ -404,6 +404,7 @@ func (b *profileBuilder) appendLocsForStack(locs []uint64, stk []uintptr) (newLo\n \tb.deck.reset()\n \n \t// The last frame might be truncated. Recover lost inline frames.\n+\torigStk := stk\n \tstk = runtime_expandFinalInlineFrame(stk)\...
2024-10-01T17:12:39
facebook/react
55a21ef7e78a4e35302cbc7ffb19934a23cc6957
069d23bb74939c19bc8860ad4013324bd6e1c5f3
fix pushTransition for transition tracing (#24338) We forgot to move pushTransition out from the enableCache flag in #24321 in a place that both transition tracing and cache need to push transitions. Move it out from behind the enableCache to prepare for the next PRs.
[ { "path": "packages/react-reconciler/src/ReactFiberBeginWork.new.js", "patch": "@@ -748,14 +748,16 @@ function updateOffscreenComponent(\n \n subtreeRenderLanes = mergeLanes(prevState.baseLanes, renderLanes);\n \n+ let prevCachePool = null;\n if (enableCache) {\n // If the render th...
2022-04-11T21:54:25
electron/electron
2b897c8ad83296aeee8c1321fcbd411a0f353fcb
0cabff0a2166b8f0554a774b813cd281d277046e
fix: crash due to race between attach and destruction of webview (#24344)
[ { "path": "lib/browser/guest-view-manager.ts", "patch": "@@ -15,6 +15,7 @@ interface GuestInstance {\n }\n \n const webViewManager = process._linkedBinding('electron_browser_web_view_manager');\n+const eventBinding = process._linkedBinding('electron_browser_event');\n \n const supportedWebViewEvents = Objec...
2021-08-02T15:35:57
nodejs/node
f970087147a30e62cdd1ebe8396d745195b8b473
a3020dd4257c7f33889fc7145db938345c94987d
deps: V8: backport 93b1a74cbc9b Original commit message: Reland "[api] allow v8::Data as internal field" This is a reland of commit 0aa622e12893e9921c01a34ce9507b544e599c4a The original patch tried to run a test that calls exit() in the fatal error handler in parallel, which would not work. This mar...
[ { "path": "common.gypi", "patch": "@@ -36,7 +36,7 @@\n \n # Reset this number to 0 on major V8 upgrades.\n # Increment by one for each non-official patch applied to deps/v8.\n- 'v8_embedder_string': '-node.15',\n+ 'v8_embedder_string': '-node.16',\n \n ##### V8 defaults for Node.js #####\n...
2023-09-11T11:29:02
vercel/next.js
15a0dee80a6fb2f41fdeb10ca5e42e59eb979228
633878112ef34fd569486c969261c3350509680d
[dev-overlay] fix styling on overflow error messages, add button hover state (#76771) Small inconsistency between the overflow gradient on the overlay in production and in code. This should fix it :") Before: ![CleanShot 2025-03-03 at 17 23 01@2x](https://github.com/user-attachments/assets/41033f5a-9cc2-4b2d-8af7-f4c...
[ { "path": "packages/next/src/client/components/react-dev-overlay/ui/components/errors/error-message/error-message.tsx", "patch": "@@ -74,7 +74,7 @@ export const styles = `\n background: linear-gradient(\n 180deg,\n rgba(250, 250, 250, 0) 0%,\n- var(--color-background-200) 100%\n+ v...
2025-03-03T22:47:34
facebook/react
069d23bb74939c19bc8860ad4013324bd6e1c5f3
4997515b96eede5ab1ca622e0439a0707f8d4afd
[eslint-plugin-exhaustive-deps] Fix exhaustive deps check for unstable vars (#24343) * Fix exhaustive deps for unstable vars * Fix formatting * Optimise iterations * Fix linting
[ { "path": "packages/eslint-plugin-react-hooks/__tests__/ESLintRuleExhaustiveDeps-test.js", "patch": "@@ -1095,6 +1095,22 @@ const tests = {\n }\n `,\n },\n+ {\n+ code: normalizeIndent`\n+ function Counter(unstableProp) {\n+ let [count, setCount] = useState(0);\n+ ...
2022-04-11T20:43:16
rust-lang/rust
20a94d65e5e6ea1c187fe14e5ae79a7078dcd206
a47f4dfd7f496ed51a383c540497899f9e3f91b4
Bump `diesel` to the most recent commit in `cargotest` `cargotest` can only detect the worst offenders (like tests failing, or hard compiler errors / ICEs), but regardless, bumping `diesel` to a way more recent version hopefully contributes slightly towards helping us not break `diesel` if at all possible.
[ { "path": "src/tools/cargotest/main.rs", "patch": "@@ -84,7 +84,7 @@ const TEST_REPOS: &[Test] = &[\n Test {\n name: \"diesel\",\n repo: \"https://github.com/diesel-rs/diesel\",\n- sha: \"91493fe47175076f330ce5fc518f0196c0476f56\",\n+ sha: \"3db7c17c5b069656ed22750e84d6498c...
2026-01-08T15:55:57
golang/go
bae2e968e2daadd39c1bdb1221648361d7277ddc
0206eb9679dd3819c44912e6ebdba3b0fbf959a3
go/parser, syntax: better error message for parameter missing type Fixes #69506. Change-Id: I18215e11f214b12d5f65be1d1740181e427f8817 Reviewed-on: https://go-review.googlesource.com/c/go/+/617015 Reviewed-by: Alan Donovan <adonovan@google.com> Reviewed-by: Robert Griesemer <gri@google.com> LUCI-TryBot-Result: Go LUCI...
[ { "path": "src/cmd/compile/internal/syntax/parser.go", "patch": "@@ -2075,26 +2075,31 @@ func (p *parser) paramList(name *Name, typ Expr, close token, requireNames bool)\n \t\t\t}\n \t\t}\n \t\tif errPos.IsKnown() {\n+\t\t\t// Not all parameters are named because named != len(list).\n+\t\t\t// If named == t...
2024-09-30T21:10:40
electron/electron
888ac65c72df227ed4d65d9177748d4082b13b0f
c0e72bd3357c1edaff30087307690d4a113bd01a
fix: toggleDevTools menu role closes devtools window (#29922)
[ { "path": "lib/browser/api/menu-item-roles.ts", "patch": "@@ -143,7 +143,10 @@ export const roleList: Record<RoleId, Role> = {\n label: 'Toggle Developer Tools',\n accelerator: isMac ? 'Alt+Command+I' : 'Ctrl+Shift+I',\n nonNativeMacOSRole: true,\n- windowMethod: w => w.webContents.toggleDevT...
2021-08-02T01:58:28
nodejs/node
ae115d68e010cf8860e15a5e8259e7dc520b26a5
705e623ac4059541eb2ded78c5b4e234e2c5ca67
zlib: disable CRC32 SIMD optimization It seems that the optimization causes memory corruption. Disable it until the issue is fixed upstream. Fixes: https://github.com/nodejs/node/issues/45268 PR-URL: https://github.com/nodejs/node/pull/49511 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Yagiz Nizipli <...
[ { "path": "deps/zlib/zlib.gyp", "patch": "@@ -107,33 +107,33 @@\n }],\n ],\n }, # zlib_arm_crc32\n- {\n- 'target_name': 'zlib_crc32_simd',\n- 'type': 'static_library',\n- 'conditions': [\n- ['OS!=\"win\" or llvm_version!=\"0.0\"', {\...
2023-09-10T05:44:49
vercel/next.js
f5e2dcc7df7cc4ac825e025cd6430250c435d7e3
e45411e9455a4f91da53cb3db638f85abac0f4bf
Update use-cache-unknown-cache-kind.test.ts snapshot for alternate bundler (#76682) This adds a snapshot for rspack to this test. It also mentions rspack instead of webpack when failing with build errors. Test Plan: `pnpm test-start-rspack test/e2e/app-dir/use-cache-unknown-cache-kind/use-cache-unknown-cache-kind.tes...
[ { "path": "packages/next/errors.json", "patch": "@@ -658,5 +658,6 @@\n \"657\": \"revalidate must be a number for image-cache\",\n \"658\": \"Pass `Infinity` instead of `false` if you want to cache on the server forever without checking with the origin.\",\n \"659\": \"SSG should not return an image c...
2025-03-03T20:12:31
facebook/react
f993ffc5141a58e2a53d4b822b15744b0542aa93
fa580022624974f4a8d0e0a3b67e1dc2fd54d583
Fix infinite update loop that happens when an unmemoized value is passed to useDeferredValue (#24247) * Fix infinite loop if unmemoized val passed to uDV The current implementation of useDeferredValue will spawn a new render any time the input value is different from the previous one. So if you pass an unmemoized...
[ { "path": "packages/react-devtools-shared/src/__tests__/preprocessData-test.js", "patch": "@@ -1463,7 +1463,9 @@ describe('Timeline profiler', () => {\n expect(event.warning).toBe(null);\n });\n \n- it('should warn about long nested (state) updates during layout effects', asyn...
2022-04-11T16:34:03
rust-lang/rust
331f75f4a773fadba135664190905457946ea98e
bcf3c082306ea9129c23e8c4e05719fcad9ca25a
Do not warn on arithmetic side effect for `String`+`String` The previous fix only handled `String`+`str`.
[ { "path": "clippy_lints/src/operators/arithmetic_side_effects.rs", "patch": "@@ -33,7 +33,10 @@ impl ArithmeticSideEffects {\n allowed_binary.extend([\n (\"f32\", FxHashSet::from_iter([\"f32\"])),\n (\"f64\", FxHashSet::from_iter([\"f64\"])),\n- (\"std::string::Str...
2026-01-08T15:37:55
golang/go
1d0f5c478ac176fa99d0f3d6bd540e5fb422187a
846fc6345d7121911376ab336e6b46fef2dd240f
errors: reference Go 1.13 article about errors This commit amends package errors' documentation to include a reference to the https://go.dev/blog/go1.13-errors blog article. The motivation is multi-fold, but chiefly the article includes good information about error philosophy (e.g., when to wrap), and developers who h...
[ { "path": "src/errors/errors.go", "patch": "@@ -26,6 +26,9 @@\n // itself followed by the tree of each of its children in turn\n // (pre-order, depth-first traversal).\n //\n+// See https://go.dev/blog/go1.13-errors for a deeper discussion of the\n+// philosophy of wrapping and when to wrap.\n+//\n // [Is] ...
2024-09-28T14:25:38
electron/electron
c0e72bd3357c1edaff30087307690d4a113bd01a
ced2e8779fb4e4a50f7fb39b4845e4ae7a396234
docs: update to the use of arrow functions in line with the style guide (#30194) * docs: Update to the use of arrow functions in line with the style guide * docs: Fixed unmatched bracket typo in previous commit 9ebe3e58f7948c6636d77f3c58a2693683b69691 * fix linting Co-authored-by: Cheng Zhao <zcbenz@gmail.com...
[ { "path": "docs/tutorial/accessibility.md", "patch": "@@ -21,7 +21,7 @@ In the testing framework Spectron, you can now audit each window and `<webview>`\n tag in your application. For example:\n \n ```javascript\n-app.client.auditAccessibility().then(function (audit) {\n+app.client.auditAccessibility().then...
2021-08-02T01:57:37
nodejs/node
b5000371c6a5a77fe4567973cebb425868f0bd38
a4d0629f551f3196b0af89975d665de2604b7abf
doc: save user preference for JS flavor PR-URL: https://github.com/nodejs/node/pull/49526 Fixes: https://github.com/nodejs/node/issues/49508 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
[ { "path": "doc/api_assets/api.js", "patch": "@@ -136,6 +136,29 @@\n updateHashes();\n }\n \n+ function setupFlavorToggles() {\n+ const kFlavorPreference = 'customFlavor';\n+ const flavorSetting = localStorage.getItem(kFlavorPreference) === 'true';\n+ const flavorToggles = document.querySelec...
2023-09-09T22:06:53
vercel/next.js
e45411e9455a4f91da53cb3db638f85abac0f4bf
094032074384ba9f7a98ea1ae7a45472d85abcaf
Fix flaky Bun test (#76763)
[ { "path": "test/integration/create-next-app/package-manager/bun.test.ts", "patch": "@@ -1,3 +1,5 @@\n+import execa from 'execa'\n+import * as semver from 'semver'\n import {\n command,\n DEFAULT_FILES,\n@@ -7,11 +9,9 @@ import {\n useTempDir,\n } from '../utils'\n \n-const lockFile = 'bun.lockb'\n-con...
2025-03-03T19:36:28
facebook/react
fa580022624974f4a8d0e0a3b67e1dc2fd54d583
0568c0f8cde4ac6657dff9a5a8a7112acc35a748
[Fizz] Pipeable Stream Perf (#24291) * Add fixture for comparing baseline render perf for renderToString and renderToPipeableStream Modified from ssr2 and https://github.com/SuperOleg39/react-ssr-perf-test * Implement buffering in pipeable streams The previous implementation of pipeable streaming (Node) suffe...
[ { "path": "fixtures/fizz/README.md", "patch": "@@ -0,0 +1,30 @@\n+# Fizz Fixtures\n+\n+A set of basic tests for Fizz primarily focussed on baseline perfomrance of legacy renderToString and streaming implementations.\n+\n+## Setup\n+\n+To reference a local build of React, first run `npm run build` at the roo...
2022-04-11T16:13:44
golang/go
c7f70433d9110e0f2be9be025545a9eeaa6b5dbc
f4b7291d73c40af90fdbc5fa0d72a26c5f127931
go/ast: update (*File).Imports field in SortImports Fixes #69694 Change-Id: I7884d42482f4f9d17e7d050d7c7730f20948169d GitHub-Last-Rev: ecd6efabaa43cc87e31e94002febc9ed4273125a GitHub-Pull-Request: golang/go#69695 Reviewed-on: https://go-review.googlesource.com/c/go/+/616340 Reviewed-by: Michael Knyszek <mknyszek@goog...
[ { "path": "src/go/ast/import.go", "patch": "@@ -51,6 +51,16 @@ func SortImports(fset *token.FileSet, f *File) {\n \t\t\t}\n \t\t}\n \t}\n+\n+\t// Make File.Imports order consistent.\n+\tf.Imports = f.Imports[:0]\n+\tfor _, decl := range f.Decls {\n+\t\tif decl, ok := decl.(*GenDecl); ok && decl.Tok == token...
2024-09-30T16:29:40
facebook/react
60e63b960f19d4c846cf32d47d2a974297ae253a
ec52a5698e2dfea7050a0b015f0b79abfb2d81b7
remove console.error in ReactFiberLane (#24319) We changed the implementation of root.transitionLanes so that, if there is no transitions for a given lane, we use null instead of an array. This means that this error is no longer valid, so we are removing it
[ { "path": "packages/react-reconciler/src/ReactFiberLane.new.js", "patch": "@@ -859,13 +859,6 @@ export function clearTransitionsForLanes(root: FiberRoot, lanes: Lane | Lanes) {\n const transitions = root.transitionLanes[index];\n if (transitions !== null) {\n root.transitionLanes[index] = null...
2022-04-08T22:33:52
electron/electron
9a63d96e83438aa1fa7d3ab2d2c2021c9e8329be
7b5deb2f3abd909a664c8aaaf0602bd6728c8088
fix: respect LogJsConsoleMessages feature in InspectableWebContents::DidAddMessageToConsole (#30312)
[ { "path": "shell/browser/ui/inspectable_web_contents.cc", "patch": "@@ -971,20 +971,6 @@ void InspectableWebContents::WebContentsDestroyed() {\n view_->GetDelegate()->DevToolsClosed();\n }\n \n-bool InspectableWebContents::DidAddMessageToConsole(\n- content::WebContents* source,\n- blink::mojom::C...
2021-07-30T17:18:49
nodejs/node
5bb0cb2660536f1acc6e0f939c48cb265862cf5c
b64c3ee6cb233249476abaec7b6c4e05b690f7d0
typings: fix missing property in `ExportedHooks` PR-URL: https://github.com/nodejs/node/pull/49567 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
[ { "path": "lib/internal/modules/esm/hooks.js", "patch": "@@ -73,6 +73,7 @@ let importMetaInitializer;\n \n /**\n * @typedef {object} ExportedHooks\n+ * @property {Function} initialize Customizations setup hook.\n * @property {Function} globalPreload Global preload hook.\n * @property {Function} resolve R...
2023-09-09T20:06:29
vercel/next.js
6dc85796c257b3632d37d09901cea5b23fe6835b
ead6e95fc1c16c63e567a403c766ab5a61b2cc91
fix edge runtime asset fetch in pages api (#76750) ### What We discoved an issue that fetch new URL with static assets in Pages API on edge runtime were failing. Located the issue was an introduced in #66534 where we changed the layer of Pages API with edge runtime entries into API layer, where it actually should b...
[ { "path": "packages/next/src/build/entries.ts", "patch": "@@ -424,7 +424,10 @@ export function getEdgeServerEntry(opts: {\n ).toString('base64'),\n }\n \n- return `next-edge-function-loader?${stringify(loaderParams)}!`\n+ return {\n+ import: `next-edge-function-loader?${stringify(loader...
2025-03-03T17:33:08
golang/go
3637ebf1e0d833234c1025db1faceeae6fe6ecbb
86781963cc2bf0d3dbd1eccebd8a2f080846f3ee
crypto/internal/cryptotest: fix typos in AEAD test comments Some comments that describe the behavior being tested don't match the test logic. Fix the comments to match test logic and documented behavior. Change-Id: I065d9d9069fa00bb865209f48e112456384c2b9d Reviewed-on: https://go-review.googlesource.com/c/go/+/61633...
[ { "path": "src/crypto/internal/cryptotest/aead.go", "patch": "@@ -108,7 +108,7 @@ func TestAEAD(t *testing.T, mAEAD MakeAEAD) {\n \n \t\t// Test all combinations of plaintext and additional data lengths.\n \t\tfor _, ptLen := range lengths {\n-\t\t\tif ptLen <= 1 { // We need enough room for an overlap to o...
2024-09-27T18:04:33
facebook/react
ec52a5698e2dfea7050a0b015f0b79abfb2d81b7
46db4e996d686ffbc8ec4cc7d559d6897288b780
Fix: Don't call cWU if already unmounted When a tree goes offscreen, we unmount all the effects just like we would in a normal deletion. (Conceptually it _is_ a deletion; we keep the fiber around so we can reuse its state if the tree mounts again.) If an offscreen component gets deleted "for real", we shouldn't unmou...
[ { "path": "packages/react-reconciler/src/ReactFiberCommitWork.new.js", "patch": "@@ -1604,7 +1604,9 @@ function commitDeletionEffectsOnFiber(\n // that don't modify the stack.\n switch (deletedFiber.tag) {\n case HostComponent: {\n- safelyDetachRef(deletedFiber, nearestMountedAncestor);\n+ ...
2022-04-07T03:47:17
electron/electron
639f03977f97d53913f294231cd1ea973449ccf7
9cc1b556632b4840dcb8787cdb29e0ad285b5c94
fix: BrowserViews not painting their WebContents (#29919)
[ { "path": "shell/browser/native_browser_view_views.cc", "patch": "@@ -7,7 +7,7 @@\n #include <vector>\n \n #include \"shell/browser/ui/drag_util.h\"\n-#include \"shell/browser/ui/inspectable_web_contents_view.h\"\n+#include \"shell/browser/ui/views/inspectable_web_contents_view_views.h\"\n #include \"ui/gfx...
2021-07-29T23:59:24
nodejs/node
0a2ab4c77c656660b2f6d5636a9b3bfdc9ca7cd1
718981ef56d0d4dd0cca3f46a7764c6c93a5f384
2023-09-08, Version 20.6.1 (Current) Notable changes: esm: * fix loading of CJS modules from ESM (Antoine du Hamel) https://github.com/nodejs/node/pull/49500 PR-URL: https://github.com/nodejs/node/pull/49528
[ { "path": "CHANGELOG.md", "patch": "@@ -35,7 +35,8 @@ release.\n </tr>\n <tr>\n <td valign=\"top\">\n-<b><a href=\"doc/changelogs/CHANGELOG_V20.md#20.6.0\">20.6.0</a></b><br/>\n+<b><a href=\"doc/changelogs/CHANGELOG_V20.md#20.6.1\">20.6.1</a></b><br/>\n+<a href=\"doc/changelogs/CHANGELOG_V20.md#20.6.0\">2...
2023-09-07T12:31:16
vercel/next.js
ead6e95fc1c16c63e567a403c766ab5a61b2cc91
bd3933571344dbe7665909c589ebae9c3ea4a810
Fix: missing close brace in demo code (#76549) Upon reading the documentation, I found the demo TypeScript code in server components section is missing a close brace. So adding it back to fix the issue. Thanks for reviewing! <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is...
[ { "path": "docs/01-app/01-getting-started/07-updating-data.mdx", "patch": "@@ -44,6 +44,7 @@ export default function Page() {\n 'use server'\n // Update data\n // ...\n+ }\n \n return <></>\n }", "additions": 1, "deletions": 0, "language": "Unknown" } ]
2025-03-03T17:31:54
golang/go
327074551a2f22f2c0b8e444d1673c86f77ca745
7fd0b133dc1bb4af59914650660c644381c84e35
cmd/go: exit non-zero if version -m is used with a non-Go file Fixes #66426 Change-Id: I5c65d5ae7863f90d654063d6385ffb6ec1308d7c GitHub-Last-Rev: 114b30eb5531b924befb12fbda28cea4663d3608 GitHub-Pull-Request: golang/go#66443 Reviewed-on: https://go-review.googlesource.com/c/go/+/573295 LUCI-TryBot-Result: Go LUCI <gol...
[ { "path": "src/cmd/go/internal/version/version.go", "patch": "@@ -92,7 +92,10 @@ func runVersion(ctx context.Context, cmd *base.Command, args []string) {\n \t\tif info.IsDir() {\n \t\t\tscanDir(arg)\n \t\t} else {\n-\t\t\tscanFile(arg, info, true)\n+\t\t\tok := scanFile(arg, info, true)\n+\t\t\tif !ok && *v...
2024-04-15T13:19:48
facebook/react
f9e6aef82880615d7d11fb9facf9edfd8c80dcf6
bcc1b3121e3052f88a643eaefe93f300a4bfa7b2
Wrap try-catch directly around each user function This moves the try-catch from around each fiber's mutation phase to direclty around each user function (effect function, callback, etc). We already do this when unmounting because if one unmount function errors, we still need to call all the others so they can clean u...
[ { "path": "packages/react-reconciler/src/ReactFiberCommitWork.new.js", "patch": "@@ -1077,21 +1077,28 @@ function hideOrUnhideAllChildren(finishedWork, isHidden) {\n if (node.tag === HostComponent) {\n if (hostSubtreeRoot === null) {\n hostSubtreeRoot = node;\n-\n- const ins...
2022-04-08T04:34:56
nodejs/node
7bf29b52b3c54a071b814ccf77cfaf275279136f
3163f8d680a43eefa925e8c52ee48ddfb56414b1
benchmark: fix webstream pipe-to PR-URL: https://github.com/nodejs/node/pull/49552 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
[ { "path": "benchmark/webstreams/pipe-to.js", "patch": "@@ -18,7 +18,7 @@ async function main({ n, highWaterMarkR, highWaterMarkW }) {\n const rs = new ReadableStream({\n highWaterMark: highWaterMarkR,\n pull: function(controller) {\n- if (i++ === n) {\n+ if (i++ < n) {\n controll...
2023-09-08T12:53:40
electron/electron
3ee6326b93e83ca18a8b55c964fc347c81c53cd2
39c3ff5292b98e30ba11c589e360ae4c1ae3148c
fix: use contentAspectRatio not aspectRatio (#30305)
[ { "path": "shell/browser/native_window_mac.mm", "patch": "@@ -1601,7 +1601,7 @@ void ViewDidMoveToSuperview(NSView* self, SEL _cmd) {\n \n // Reset the behaviour to default if aspect_ratio is set to 0 or less.\n if (aspect_ratio > 0.0)\n- [window_ setAspectRatio:NSMakeSize(aspect_ratio, 1.0)];\n+ ...
2021-07-29T21:27:21
golang/go
7fd0b133dc1bb4af59914650660c644381c84e35
49dd7726a9e2e4371de984871082ea0e3791cbdd
cmd/go: add Mercurial based version stamping for binaries This CL adds a local only VCS lookup for Mercurial. It fixes a bug in pkg.go by passing in the repo directory to the LookupLocal function instead of the module directory. It could be the case that a binary is built in a subdirectory of the repo. For: #50603 Cq...
[ { "path": "src/cmd/go/internal/load/pkg.go", "patch": "@@ -2494,7 +2494,7 @@ func (p *Package) setBuildInfo(ctx context.Context, autoVCS bool) {\n \t\t}\n \t\tappendSetting(\"vcs.modified\", strconv.FormatBool(st.Uncommitted))\n \t\t// Determine the correct version of this module at the current revision and...
2024-08-28T16:26:30
vercel/next.js
5dc096788e7ad0ea03969d53f6e82d6c59d87eea
9118a0b609a7b701d4fd4bd7846dd939c5076428
Turbopack: avoid panic in module batches (#76757) Because of eventual consistency
[ { "path": "turbopack/crates/turbopack-core/src/module_graph/module_batches.rs", "patch": "@@ -4,7 +4,7 @@ use std::{\n mem::take,\n };\n \n-use anyhow::{bail, Result};\n+use anyhow::{bail, Context, Result};\n use either::Either;\n use petgraph::graph::{DiGraph, EdgeIndex, NodeIndex};\n use rustc_hash::{...
2025-03-03T14:43:48
facebook/react
bcc1b3121e3052f88a643eaefe93f300a4bfa7b2
c99c5f1df6e3c274d34bd2e5f0b27ac4af481f94
Move reportUncaughtErrorInDev to captureCommitPhaseError reportUncaughtErrorInDev is always followed by captureCommitPhaseError, so we can move it into that function.
[ { "path": "packages/react-reconciler/src/ReactFiberCommitWork.new.js", "patch": "@@ -180,7 +180,7 @@ let nextEffect: Fiber | null = null;\n let inProgressLanes: Lanes | null = null;\n let inProgressRoot: FiberRoot | null = null;\n \n-function reportUncaughtErrorInDEV(error) {\n+export function reportUncaugh...
2022-04-08T04:05:15
electron/electron
39c3ff5292b98e30ba11c589e360ae4c1ae3148c
4aa94556130760b6bab8e22b3f9e436c8d4aabf4
fix: guard against missing native view (#30304)
[ { "path": "shell/browser/api/electron_api_browser_window_views.cc", "patch": "@@ -17,14 +17,16 @@ void BrowserWindow::UpdateDraggableRegions(\n return;\n \n if (&draggable_regions_ != &regions) {\n- auto const offset =\n- web_contents()->GetNativeView()->GetBoundsInRootWindow();\n- auto s...
2021-07-29T21:27:02
nodejs/node
0bce573bd4e6b768f679d29783a8180820026a90
cd49408ff1a957240da044c68bfe201703d3c0c4
src: fix fs_type_to_name default value PR-URL: https://github.com/nodejs/node/pull/49239 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: theanarkh <theratliter@gmail.com>
[ { "path": "src/node_dir.cc", "patch": "@@ -53,7 +53,7 @@ static const char* get_dir_func_name_by_type(uv_fs_type req_type) {\n FS_TYPE_TO_NAME(CLOSEDIR, \"closedir\")\n #undef FS_TYPE_TO_NAME\n default:\n- return \"unknow\";\n+ return \"unknown\";\n }\n }\n ", "additions": 1, "de...
2023-09-07T19:14:33
golang/go
49dd7726a9e2e4371de984871082ea0e3791cbdd
6536c207c2309da7c1c21e3669f8ddf491e31f5b
internal/testlog: use atomic.Pointer instead of atomic.Value We know the type (*Interface), so we can use the generic atomic.Pointer. This change also makes sure that concurrent use of SetLogger also causes a panic, currently it races (Load, then Store). Change-Id: I6fae5ce0587b37eede2060342c3fcd0cde4386ff GitHub-Las...
[ { "path": "src/internal/testlog/log.go", "patch": "@@ -21,20 +21,19 @@ type Interface interface {\n }\n \n // logger is the current logger Interface.\n-// We use an atomic.Value in case test startup\n+// We use an atomic.Pointer in case test startup\n // is racing with goroutines started during init.\n // T...
2024-09-28T16:50:03
vercel/next.js
9118a0b609a7b701d4fd4bd7846dd939c5076428
f1256388bb3d00ba328a5a90689f8763832a2bab
Keep server code out of browser chunks (#76660) Reduces the main chunk's size for a hello world app ~from 60.2 kB to 51.6 kB~ from 53.5 kB to 45.6 kB (after #76622 got merged). In the past we were a bit sloppy with using modules from `src/server` also in universally used modules (server & browser). This led to code e...
[ { "path": "packages/next/src/build/normalize-catchall-routes.ts", "patch": "@@ -1,4 +1,4 @@\n-import { isInterceptionRouteAppPath } from '../server/lib/interception-routes'\n+import { isInterceptionRouteAppPath } from '../shared/lib/router/utils/interception-routes'\n import { AppPathnameNormalizer } from '...
2025-03-03T14:17:45
facebook/react
ea7b2ec2898c615f648aec30fcbcf73aed156583
8dcedba15a4a0f5545e3b386355000208884b24f
Remove wrong return pointer warning I'm about to refactor part of the commit phase to use recursion instead of iteration. As part of that change, we will no longer assign the `return` pointer when traversing into a subtree. So I'm disabling the internal warning that fires if the return pointer is not consistent with t...
[ { "path": "packages/react-dom/src/__tests__/ReactWrongReturnPointer-test.js", "patch": "@@ -153,51 +153,6 @@ function resolveMostRecentTextCache(text) {\n \n const resolveText = resolveMostRecentTextCache;\n \n-// Don't feel too guilty if you have to delete this test.\n-// @gate dfsEffectsRefactor\n-// @gat...
2022-04-07T03:01:07
electron/electron
fa464286ee10c091295b9d222e2845256d84332b
d63980edebddc23ce765655b24db91ef3f8110a3
test: deflake crashReporter.getLastCrashReport test (#30276)
[ { "path": "spec-main/api-crash-reporter-spec.ts", "patch": "@@ -3,7 +3,7 @@ import * as childProcess from 'child_process';\n import * as http from 'http';\n import * as Busboy from 'busboy';\n import * as path from 'path';\n-import { ifdescribe, ifit, defer, startRemoteControlApp, delay } from './spec-helpe...
2021-07-28T15:56:15
nodejs/node
c86e700b3ee5efc4f5b3ed878484b5d50f34eec9
941ad8b843aed27a69739c9fd42312c6c76c3032
src: fix comment on StreamResource PR-URL: https://github.com/nodejs/node/pull/49193 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
[ { "path": "src/stream_base.h", "patch": "@@ -225,7 +225,7 @@ class StreamResource {\n // These need to be implemented on the readable side of this stream:\n \n // Start reading from the underlying resource. This is called by the consumer\n- // when more data is desired. Use `EmitAlloc()` and `EmitData(...
2023-08-16T08:22:10
golang/go
6536c207c2309da7c1c21e3669f8ddf491e31f5b
0fb33863b78c03f4f3d6228e310869f2edff1195
net: improve GODEBUG=netdns=1 debug messages Fixes #69680 Change-Id: I73b0506c7a3245ba282cffabe47543f5fce86692 GitHub-Last-Rev: 4c6a1a4c706f39d2756c65b72b78896cd4881302 GitHub-Pull-Request: golang/go#69684 Reviewed-on: https://go-review.googlesource.com/c/go/+/616263 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-pr...
[ { "path": "src/net/conf.go", "patch": "@@ -93,19 +93,30 @@ func initConfVal() {\n \t\t\tif confVal.dnsDebugLevel > 1 {\n \t\t\t\tprintln(\"go package net: confVal.netCgo =\", confVal.netCgo, \" netGo =\", confVal.netGo)\n \t\t\t}\n+\t\t\tif dnsMode != \"go\" && dnsMode != \"cgo\" && dnsMode != \"\" {\n+\t\t...
2024-09-27T19:57:12
vercel/next.js
f1256388bb3d00ba328a5a90689f8763832a2bab
d7f5730124d1fded69e94ec44a0f003ea3c1f782
[test] Use new Redbox matchers in app/ rsc-runtime-errors (#76745) <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## F...
[ { "path": "test/development/acceptance-app/rsc-runtime-errors.test.ts", "patch": "@@ -1,15 +1,9 @@\n import path from 'path'\n import { outdent } from 'outdent'\n import { FileRef, nextTestSetup } from 'e2e-utils'\n-import {\n- assertHasRedbox,\n- getRedboxDescription,\n- getRedboxSource,\n- getVersionC...
2025-03-03T13:41:57
facebook/react
8dcedba15a4a0f5545e3b386355000208884b24f
b86baa1cb7b0838169eb762873d53442b9075c94
Add fallback shim for AbortController (#24285) * Add fallback shim for AbortController * Replace shim with a minimal stub * replace-fork * Better minification * Fix flow * Even smaller * replace-fork * Revert back to object constructor * replace-fork
[ { "path": "packages/react-dom/src/__tests__/ReactDOMFizzServerBrowser-test.js", "patch": "@@ -12,7 +12,6 @@\n // Polyfills for test environment\n global.ReadableStream = require('web-streams-polyfill/ponyfill/es6').ReadableStream;\n global.TextEncoder = require('util').TextEncoder;\n-global.AbortController ...
2022-04-08T19:53:40
electron/electron
1c95d30c0fb62eac5b9a7b4f5ccaa2555c9d3bb1
fc7ea750094a6d286b150f6b1ed1cb8d5b843477
fix: Add missing items to menuItem.role documentation (#30217)
[ { "path": "docs/api/menu-item.md", "patch": "@@ -14,7 +14,7 @@ See [`Menu`](menu.md) for examples.\n * `menuItem` MenuItem\n * `browserWindow` [BrowserWindow](browser-window.md) | undefined - This will not be defined if no window is open.\n * `event` [KeyboardEvent](structures/keyboard-event.md)...
2021-07-28T06:45:06
rust-lang/rust
2afe5b1a837b5e4d1cb27f675218de4c800d2b80
d9617c8d9a55773a96b61ba3a4acb107d65615c1
Fix ICE in inline always warning emission. The calls to `def_path_str` were outside the decorate callback in `node_span_lint` which caused an ICE when the warning was an allowed warning due to the call to `def_path_str` being executed but the warning not actually being emitted.
[ { "path": "compiler/rustc_mir_transform/src/errors.rs", "patch": "@@ -19,14 +19,14 @@ pub(crate) fn emit_inline_always_target_feature_diagnostic<'a, 'tcx>(\n caller_def_id: DefId,\n callee_only: &[&'a str],\n ) {\n- let callee = tcx.def_path_str(callee_def_id);\n- let caller = tcx.def_path_str...
2026-01-08T11:59:41
nodejs/node
6b135a1a20b292c0cbbcbcc948cc24e8f2d48699
306de763f29f68d66eddfa2308198b7831afdb0b
doc: fix documentation for input option in child_process PR-URL: https://github.com/nodejs/node/pull/49481 Fixes: https://github.com/nodejs/node/issues/49417 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
[ { "path": "doc/api/child_process.md", "patch": "@@ -925,8 +925,8 @@ changes:\n * `options` {Object}\n * `cwd` {string|URL} Current working directory of the child process.\n * `input` {string|Buffer|TypedArray|DataView} The value which will be passed\n- as stdin to the spawned process. Supplying this ...
2023-09-06T21:08:18
golang/go
2bffb8b3fb2d9137ccfa87fc35137371b86a2e96
eb6f2c24cd17c0ca1df7e343f8d9187eef7d6e13
slices: prevent Clone keeping alive the array when cloning empty slices Fixes #68488 Change-Id: I39aba22cdfe8ca0bbe69db7c64f1bca75fa067fa Reviewed-on: https://go-review.googlesource.com/c/go/+/598875 Reviewed-by: Keith Randall <khr@golang.org> Commit-Queue: Ian Lance Taylor <iant@google.com> Reviewed-by: Keith Randal...
[ { "path": "src/slices/slices.go", "patch": "@@ -346,8 +346,13 @@ func Replace[S ~[]E, E any](s S, i, j int, v ...E) S {\n // The elements are copied using assignment, so this is a shallow clone.\n // The result may have additional unused capacity.\n func Clone[S ~[]E, E any](s S) S {\n-\t// The s[:0:0] pres...
2024-07-17T12:15:32
facebook/react
a9add2fe08cc3fa8fc811f6efce84815827fb98c
bafe912a5f20736c40f505a47fcb238a375572a6
Fix file path separator compatibility in scripts/babel (#24318) The problem in scripts\babel\transform-object-assign.js is that file path separator has '/' and '\' between Linux, MacOS and Windows, which causes yarn build error. See https://github.com/facebook/react/issues/24103
[ { "path": "scripts/babel/transform-object-assign.js", "patch": "@@ -28,7 +28,7 @@ module.exports = function autoImporter(babel) {\n \n visitor: {\n CallExpression: function(path, file) {\n- if (file.filename.indexOf('shared/assign') !== -1) {\n+ if (/shared(\\/|\\\\)assign/.test(file...
2022-04-08T18:47:31
vercel/next.js
d7f5730124d1fded69e94ec44a0f003ea3c1f782
b400f8ec94314e8f60d591fa38e353ce77d62647
[Dev Tools] Improve keyboard interactions for menu & overlays (#76754) This PR implements robust keyboard navigation for the Dev Tools dropdown menu, and its nested overlays that appear. Full list of changes: - Use enum state `open` for making sure only one overlay can be open at a time - Implement proper focus trapp...
[ { "path": "packages/next/src/client/components/react-dev-overlay/ui/components/errors/dev-tools-indicator/dev-tools-indicator.tsx", "patch": "@@ -1,4 +1,4 @@\n-import type { Dispatch, SetStateAction } from 'react'\n+import type { CSSProperties, Dispatch, SetStateAction } from 'react'\n import { STORAGE_KEY_...
2025-03-03T13:10:08
nodejs/node
6919d7241657517bfff6d2041748fa9f8e85b76e
fdc65d97699212b4c967206e3bbe171fe10734f7
doc: fix missing imports in `test.run` code examples The script was missing necessary imports for the `run` function and the `path` module, causing it to fail. This commit adds the missing imports and resolves the issue. - Import `run` from the appropriate module. - Import `path` to resolve file paths. The script sh...
[ { "path": "doc/api/test.md", "patch": "@@ -908,7 +908,9 @@ changes:\n \n ```mjs\n import { tap } from 'node:test/reporters';\n+import { run } from 'node:test';\n import process from 'node:process';\n+import path from 'node:path';\n \n run({ files: [path.resolve('./tests/test.js')] })\n .compose(tap)\n@@ -...
2023-09-06T18:17:54
electron/electron
a545cd37902d490297310b4c04a6bd2094999a10
461db8f1ab6d6fef0a634931347b7e6526b3f953
fix: type internal APIs that can return null properly (#29852)
[ { "path": "lib/browser/devtools.ts", "patch": "@@ -67,7 +67,7 @@ ipcMainInternal.handle(IPC_MESSAGES.INSPECTOR_CONTEXT_MENU, function (event, ite\n \n const template = isEditMenu ? getEditMenuItems() : convertToMenuTemplate(items, resolve);\n const menu = Menu.buildFromTemplate(template);\n- cons...
2021-07-27T05:48:12
golang/go
eb6f2c24cd17c0ca1df7e343f8d9187eef7d6e13
677b6cc17544e5e667d4bb67d063f5d775c69e32
runtime: use vDSO for getrandom() on linux Linux 6.11 supports calling getrandom() from the vDSO. It operates on a thread-local opaque state allocated with mmap using flags specified by the vDSO. Opaque states are allocated in chunks, ideally ncpu at a time as a hint, rounding up to as many fit in a complete page. On...
[ { "path": "src/crypto/rand/rand_test.go", "patch": "@@ -43,6 +43,9 @@ func TestReadEmpty(t *testing.T) {\n }\n \n func BenchmarkRead(b *testing.B) {\n+\tb.Run(\"4\", func(b *testing.B) {\n+\t\tbenchmarkRead(b, 4)\n+\t})\n \tb.Run(\"32\", func(b *testing.B) {\n \t\tbenchmarkRead(b, 32)\n \t})", "addition...
2024-09-22T01:45:29
facebook/react
1f7a901d7b2fc073e29a1887553b1bd18080da1b
f56dfe950b206651913bf0b836c10592c393357d
Fix false positive lint error with large number of branches (#24287) * Switched RulesOfHooks.js to use BigInt. Added test and updated .eslintrc.js to use es2020. * Added BigInt as readonly global in eslintrc.cjs.js and eslintrc.cjs2015.js * Added comment to RulesOfHooks.js that gets rid of BigInt eslint error ...
[ { "path": "packages/eslint-plugin-react-hooks/__tests__/ESLintRulesOfHooks-test.js", "patch": "@@ -325,6 +325,75 @@ const tests = {\n useHook();\n }\n `,\n+ `\n+ // Valid because the neither the conditions before or after the hook affect the hook call\n+ // Failed prior to imp...
2022-04-07T23:22:47
vercel/next.js
b400f8ec94314e8f60d591fa38e353ce77d62647
d4919b317d173852fe261b75d0613efed7f572c1
[test] Use new Redbox matchers in app/ dynamic-error (#76744)
[ { "path": "test/development/acceptance-app/dynamic-error.test.ts", "patch": "@@ -29,11 +29,21 @@ describe('dynamic = \"error\" in devmode', () => {\n ]),\n '/server'\n )\n- const { session } = sandbox\n- await session.assertHasRedbox()\n- const description = await session.getRedboxD...
2025-03-03T12:41:08
nodejs/node
fdc65d97699212b4c967206e3bbe171fe10734f7
cfe4166f0f9b8be2938e6e1cfd6e7b7c4daaa1ad
esm: fix loading of CJS modules from ESM PR-URL: https://github.com/nodejs/node/pull/49500 Fixes: https://github.com/nodejs/node/issues/49497 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me>
[ { "path": "lib/internal/modules/esm/translators.js", "patch": "@@ -279,7 +279,8 @@ translators.set('commonjs', async function commonjsStrategy(url, source,\n // obtained by calling the monkey-patchable CJS loader.\n const cjsLoader = source == null ? (module, source, url, filename) => {\n try {\n- ...
2023-09-06T10:12:14
electron/electron
461db8f1ab6d6fef0a634931347b7e6526b3f953
d2989de5d9b7ae4a3d860620bbf7e760fc9be5ed
fix: persist permission granted to serial ports (#30209)
[ { "path": "shell/browser/electron_browser_context.cc", "patch": "@@ -8,6 +8,8 @@\n \n #include <utility>\n \n+#include <vector>\n+\n #include \"base/barrier_closure.h\"\n #include \"base/base_paths.h\"\n #include \"base/command_line.h\"\n@@ -93,6 +95,9 @@ std::string MakePartitionName(const std::string& inp...
2021-07-26T17:10:57
facebook/react
548b542b41565340a9ffd36d0d4e5e1d244cc113
d68b09defca37c30d3a7a34d4de884e374c74858
Update renderToPipeableStream#options.onShellError to match usage (#24299)
[ { "path": "packages/react-dom/src/server/ReactDOMFizzServerNode.js", "patch": "@@ -41,7 +41,7 @@ type Options = {|\n bootstrapModules?: Array<string>,\n progressiveChunkSize?: number,\n onShellReady?: () => void,\n- onShellError?: () => void,\n+ onShellError?: (error: mixed) => void,\n onAllReady?...
2022-04-07T19:06:54
golang/go
62452bed480108623910feace4a5cea5448e6822
99bf122de86ffec5ebd85a688432619d717025fe
cmd/go: fix the accuracy of Mercurial vcs.* stamped data There were a few Mercurial command line uses that could cause the wrong data to be used: * The log command needs '-r.' to specify the currently checked out commit * HGPLAIN is needed to disable optional output on commands * '-S' is needed to for the 'status' co...
[ { "path": "src/cmd/go/internal/vcs/vcs.go", "patch": "@@ -37,6 +37,7 @@ import (\n type Cmd struct {\n \tName string\n \tCmd string // name of binary to invoke command\n+\tEnv []string // any environment values to set/override\n \tRootNames []rootName // filename and mode indicating t...
2024-08-03T00:06:30
vercel/next.js
d4919b317d173852fe261b75d0613efed7f572c1
51e00434ed114876593179129037400d89557ebc
[test] Fix flaky error-recovery test (#76753) Fixes https://github.com/vercel/next.js/actions/runs/13628820428/job/38093524162
[ { "path": "test/development/pages-dir/client-navigation/index.test.ts", "patch": "@@ -6,6 +6,7 @@ import {\n waitFor,\n check,\n retry,\n+ getRedboxTotalErrorCount,\n } from 'next-test-utils'\n import webdriver, { BrowserInterface } from 'next-webdriver'\n import path from 'path'\n@@ -1395,6 +1396,11...
2025-03-03T12:14:44
facebook/react
d68b09defca37c30d3a7a34d4de884e374c74858
0579154772af551bfccf9ff0cc7076a39316344a
Fix warning about setState in useEffect (#24295) * Fix warning about setState in useEffect * Fix test * Fix multiple roots
[ { "path": "packages/react-reconciler/src/ReactFiberWorkLoop.new.js", "patch": "@@ -396,9 +396,12 @@ let pendingPassiveEffectsRemainingLanes: Lanes = NoLanes;\n const NESTED_UPDATE_LIMIT = 50;\n let nestedUpdateCount: number = 0;\n let rootWithNestedUpdates: FiberRoot | null = null;\n+let isFlushingPassiveEf...
2022-04-07T17:06:35
rust-lang/rust
5d8a7daf2ab5d13330030880af021cf1cf418a7e
6acaa27fa690604737e662ab168caae395773d28
Fixes for builtin derive expansions - Do not store the `MacroCallId` of the "real" expansion anywhere, so that the IDE layer could not expand it by mistake - Fix a stupid bug where we used the directive of the `derive` itself instead of of the macro, leading us to re-expand it again and again.
[ { "path": "src/tools/rust-analyzer/crates/hir-def/src/builtin_derive.rs", "patch": "@@ -8,7 +8,8 @@ use intern::{Symbol, sym};\n use tt::TextRange;\n \n use crate::{\n- AdtId, BuiltinDeriveImplId, BuiltinDeriveImplLoc, FunctionId, HasModule, db::DefDatabase,\n+ AdtId, BuiltinDeriveImplId, BuiltinDeriv...
2026-01-08T07:25:28
nodejs/node
d8eb8d05f9d54a69682f999dcf7b39d85f898edc
54021850f9d56564e04079f24685fdd12f6f2a14
doc: fix documentation for fs.createWriteStream highWaterMark option PR-URL: https://github.com/nodejs/node/pull/49456 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name>
[ { "path": "doc/api/fs.md", "patch": "@@ -325,6 +325,7 @@ added: v16.11.0\n * `autoClose` {boolean} **Default:** `true`\n * `emitClose` {boolean} **Default:** `true`\n * `start` {integer}\n+ * `highWaterMark` {number} **Default:** `16384`\n * Returns: {fs.WriteStream}\n \n `options` may also include a...
2023-09-06T06:57:21
electron/electron
d2989de5d9b7ae4a3d860620bbf7e760fc9be5ed
385d0f590fe39f6e8ec87dafb2c8b22ae005901f
fix: update traffic lights position for macOS 11 (#30263)
[ { "path": "shell/browser/native_window_mac.mm", "patch": "@@ -1800,7 +1800,7 @@ void ViewDidMoveToSuperview(NSView* self, SEL _cmd) {\n [buttons_view_ setShowOnHover:YES];\n if (title_bar_style_ == TitleBarStyle::kHiddenInset &&\n !traffic_light_position_)\n- [buttons_view_ se...
2021-07-26T16:22:21